Skip to content

Conversation

jfdoming
Copy link
Member

No description provided.

@actual-github-bot actual-github-bot bot changed the title Fix a few typos mentioned on Weblate [WIP] Fix a few typos mentioned on Weblate Jun 21, 2025
Copy link

netlify bot commented Jun 21, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 720c91a
🔍 Latest deploy log https://app.netlify.com/projects/actualbudget/deploys/686855ffbf125b00084f646a
😎 Deploy Preview https://deploy-preview-5211.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jfdoming jfdoming changed the title [WIP] Fix a few typos mentioned on Weblate Fix a few typos mentioned on Weblate Jun 21, 2025
Copy link
Contributor

github-actions bot commented Jun 21, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
19 10.11 MB 0%
Changeset
File Δ Size
src/components/select/RecurringSchedulePicker.tsx 📈 +2 B (+0.01%) 17.94 kB → 17.94 kB
src/components/modals/GoCardlessExternalMsgModal.tsx 📈 +1 B (+0.01%) 10.35 kB → 10.35 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📉 -2 B (-0.02%) 8.47 kB → 8.47 kB
src/components/budget/util.ts 📉 -1 B (-0.03%) 3.32 kB → 3.32 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 7.6 MB 0%
static/js/de.js 134.73 kB 0%
static/js/en-GB.js 6.38 kB 0%
static/js/en.js 121.16 kB 0%
static/js/es.js 70.83 kB 0%
static/js/fr.js 133.74 kB 0%
static/js/nl.js 100.58 kB 0%
static/js/pt-BR.js 124.83 kB 0%
static/js/sv.js 65.13 kB 0%
static/js/th.js 190.63 kB 0%
static/js/uk.js 121.11 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ReportRouter.js 820.61 kB 0%
static/js/narrow.js 393.63 kB 0%
static/js/wide.js 115.17 kB 0%
static/js/TransactionList.js 10.92 kB 0%

Copy link
Contributor

github-actions bot commented Jun 21, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 2.25 MB 0%
Changeset
File Δ Size
packages/loot-core/src/shared/rules.ts 📉 -2 B (-0.02%) 10.71 kB → 10.71 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 2.25 MB 0%

Copy link
Contributor

coderabbitai bot commented Jun 21, 2025

Walkthrough

This change addresses minor textual and formatting corrections in four components. In the budget utility, an extra space is removed from a string passed to the translation function. In the GoCardless external message modal, the loading message is updated to use three trailing dots instead of two. In the recurring schedule picker, typographical errors in the words "occurrence" and "occurrences" are corrected. In the shared rules, the string returned for the 'hasTags' operation is changed from "has tag(s)" to "has tags." No changes are made to logic, control flow, or exported entities.

Possibly related PRs

  • Marked files for translation #3548: Adds translation support by wrapping many strings in t() calls, related by involving localization but does not overlap in the same code or functions.

Suggested labels

:sparkles: merged

Suggested reviewers

  • MikesGlitch
  • matt-fidd

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e4074e and 654d389.

⛔ Files ignored due to path filters (1)
  • upcoming-release-notes/5211.md is excluded by !**/*.md
📒 Files selected for processing (4)
  • packages/desktop-client/src/components/budget/util.ts (1 hunks)
  • packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (1 hunks)
  • packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx (1 hunks)
  • packages/loot-core/src/shared/rules.ts (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • packages/loot-core/src/shared/rules.ts
  • packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx
  • packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/desktop-client/src/components/budget/util.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Functional
  • GitHub Check: Visual regression
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (windows-latest)
  • GitHub Check: Functional Desktop App
  • GitHub Check: Analyze
  • GitHub Check: test
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

🤖 Auto-generated Release Notes

Hey @jfdoming! I've automatically created a release notes file based on CodeRabbit's analysis:

Category: Maintenance
Summary: Fix typos and improve formatting in budget utility, loading messages, and schedule picker.
File: upcoming-release-notes/5211.md

The release notes file has been committed to the repository. You can edit it if needed before merging.

@jfdoming jfdoming force-pushed the jfdoming/fix-minor-i18n-issues branch from 2e4074e to 654d389 Compare June 21, 2025 06:32
@jfdoming
Copy link
Member Author

/update-vrt

matt-fidd
matt-fidd previously approved these changes Jun 21, 2025
@matt-fidd matt-fidd self-assigned this Jun 28, 2025
@matt-fidd
Copy link
Member

/update-vrt

Copy link
Member

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfdoming any objections to merging before release? It'd be nice to get little typos sorted out.

@jfdoming
Copy link
Member Author

@jfdoming any objections to merging before release? It'd be nice to get little typos sorted out.

My only concern is that it may not give translators enough time to update the translations

@jfdoming jfdoming modified the milestones: v25.7.0, v25.8.0 Jun 29, 2025
@jfdoming jfdoming merged commit 4be7e03 into actualbudget:master Jul 9, 2025
24 checks passed
@jfdoming jfdoming deleted the jfdoming/fix-minor-i18n-issues branch July 9, 2025 01:05
passabilities added a commit to passabilities/actual-budget that referenced this pull request Jul 9, 2025
…raph

* actual/master: (120 commits)
  [Goals] limits for remainders (actualbudget#5301)
  Reword the overspending banner for tracking budget. (actualbudget#5307)
  Fix a few typos mentioned on Weblate (actualbudget#5211)
  no hidden (actualbudget#5305)
  [Goals] upgrade week template to be a periodic template (actualbudget#5295)
  [Goals] Round template amounts if hide decimals is set (actualbudget#5288)
  :electron:  Fix early server-started signification message (actualbudget#5303)
  Customize tags colors (actualbudget#5032)
  Run rules on transactions created by a transfer. (actualbudget#5279)
  add notes to scheduled transactions table (actualbudget#5290)
  💬 Added Discord link to the help menu for discoverability (actualbudget#5286)
  Fixes actualbudget#5278: Applied PrivacyFilter to balance graph display (and added conditionality whether user is hovering on the graph) (actualbudget#5281)
  add some basic linting rules for translation consistency (actualbudget#5212)
  Update contributor points calculation logic (actualbudget#5169)
  feat(currency): add currency setting and format (actualbudget#5167)
  Move remaining `.d.ts` files to `.ts` (actualbudget#5208)
  use correct running balance when adding a new transaction (actualbudget#5207)
  Fix rule templating on date causing crash (actualbudget#5259)
  Fixes actualbudget#5228 - has tag(s) filter now takes values when pressing Enter (actualbudget#5263)
  correctly ignore hidden categories when using "Set Average Budget" (actualbudget#5239)
  ...
Johnn27 pushed a commit to Johnn27/actual that referenced this pull request Aug 12, 2025
* Fix a few typos mentioned on Weblate

* Add release notes

* Update VRT

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants