Skip to content

parquet store-gateways: open labels file from bucket with flag #12091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

francoposa
Copy link
Contributor

@francoposa francoposa commented Jul 14, 2025

What this PR does

-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

@francoposa francoposa added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Jul 14, 2025
Copy link
Contributor

github-actions bot commented Jul 14, 2025

💻 Deploy preview deleted.

@francoposa francoposa marked this pull request as ready for review July 14, 2025 22:46
@francoposa francoposa requested review from tacole02 and a team as code owners July 14, 2025 22:46
@francoposa francoposa changed the title parquet store-gateways: open labels file from bucket parquet store-gateways: open labels file from bucket with flag Jul 14, 2025
@npazosmendez
Copy link
Contributor

Looks like the failing test is already failing in parquet-main. I'm gonna merge this and fix the test separately

@npazosmendez npazosmendez merged commit ead95df into parquet-main Jul 15, 2025
32 of 33 checks passed
@npazosmendez npazosmendez deleted the francoposa/parquet-sg-open-labelsfile-from-bucket branch July 15, 2025 12:24
npazosmendez pushed a commit that referenced this pull request Jul 18, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
francoposa added a commit that referenced this pull request Jul 21, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
francoposa added a commit that referenced this pull request Jul 31, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
jesusvazquez pushed a commit that referenced this pull request Aug 2, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
jesusvazquez pushed a commit that referenced this pull request Aug 2, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
jesusvazquez pushed a commit that referenced this pull request Aug 8, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
francoposa added a commit that referenced this pull request Aug 11, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
francoposa added a commit that referenced this pull request Aug 11, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
francoposa added a commit that referenced this pull request Aug 12, 2025
<!--  Thanks for sending a pull request!  Before submitting:

1. Read our CONTRIBUTING.md guide
2. Rebase your PR if it gets out of sync with main
-->

#### What this PR does
```
-blocks-storage.bucket-store.parquet-load-index-to-disk
    	True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
```


#### Which issue(s) this PR fixes or relates to

Fixes #<issue number>

#### Checklist

- [ ] Tests updated.
- [ ] Documentation added.
- [ ] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-not-needed PRs that don't need a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants