Skip to content

parquet store-gateways: open labels file from bucket with flag #12091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/mimir/config-descriptor.json
Original file line number Diff line number Diff line change
Expand Up @@ -11216,6 +11216,17 @@
"fieldType": "float",
"fieldCategory": "advanced"
},
{
"kind": "field",
"name": "parquet_load_index_to_disk",
"required": false,
"desc": "True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket.",
"fieldValue": null,
"fieldDefaultValue": true,
"fieldFlag": "blocks-storage.bucket-store.parquet-load-index-to-disk",
"fieldType": "boolean",
"fieldCategory": "advanced"
},
{
"kind": "field",
"name": "parquet_max_row_count",
Expand Down
2 changes: 2 additions & 0 deletions cmd/mimir/help-all.txt.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,8 @@ Usage of ./cmd/mimir/mimir:
How long to cache list of blocks for each tenant. (default 5m0s)
-blocks-storage.bucket-store.metadata-cache.tenants-list-ttl duration
How long to cache list of tenants in the bucket. (default 15m0s)
-blocks-storage.bucket-store.parquet-load-index-to-disk
True to download the Parquet labels file to disk before opening it. False to open it directly from the bucket. (default true)
-blocks-storage.bucket-store.parquet-max-chunk-size-bytes uint
Maximum size in bytes that can be fetched from the parquet chunks file. If the size exceeds this value the query will stop with limit error.
-blocks-storage.bucket-store.parquet-max-data-size-bytes uint
Expand Down
12 changes: 10 additions & 2 deletions development/mimir-microservices-mode/docker-compose.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ std.manifestYamlDoc({

// If true, start parquet-converter
enable_parquet: false,
// If true, emulate classic store-gateway behavior by loading the Parquet labels file to disk
parquet_store_gateway_load_index_to_disk: false,
},

// We explicitely list all important services here, so that it's easy to disable them by commenting out.
Expand Down Expand Up @@ -179,14 +181,20 @@ std.manifestYamlDoc({
for id in std.range(1, count)
},

local extraStoreGatewayArgs = std.join(
' ', [
(if $._config.enable_parquet then '-log.level=debug -store-gateway.parquet-enabled=true' else null),
(if ($._config.enable_parquet && !$._config.parquet_store_gateway_load_index_to_disk) then '-blocks-storage.bucket-store.parquet-load-index-to-disk=false' else null),
]
),

store_gateways(count):: {
['store-gateway-%d' % id]: mimirService({
name: 'store-gateway-' + id,
target: 'store-gateway',
httpPort: 8010 + id,
jaegerApp: 'store-gateway-%d' % id,
extraArguments:
if $._config.enable_parquet then '-store-gateway.parquet-enabled=true' else '',
extraArguments: extraStoreGatewayArgs,
})
for id in std.range(1, count)
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4864,6 +4864,11 @@ bucket_store:
# CLI flag: -blocks-storage.bucket-store.series-fetch-preference
[series_fetch_preference: <float> | default = 0.75]

# (advanced) True to download the Parquet labels file to disk before opening
# it. False to open it directly from the bucket.
# CLI flag: -blocks-storage.bucket-store.parquet-load-index-to-disk
[parquet_load_index_to_disk: <boolean> | default = true]

# (advanced) Maximum number of rows in a parquet file. If the number of rows
# exceeds this value the query will stop with limit error.
# CLI flag: -blocks-storage.bucket-store.parquet-max-row-count
Expand Down
Loading
Loading