fix: rebuild lyra_proc if .env is changed #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuild `lyra_proc` crate if `.env` is changed, left out of #64. This makes the `/play` sources to be reevaluated every time `.env` changes, instead of incorrectly on every cold build.
fdnt7
added a commit
that referenced
this pull request
Jun 19, 2025
* fix: sync /play src opt choices w/ .env at runtime Sync `/play`'s 'source' option choices with enabled play sources enabled in `.env` at runtime instead of build time. This allows prebuilt images to declare the new source option choices when `.env` is changed accordingly. refs: #64, #77 * fix: include display_name in runtime .env syncing Also refactor string literals out to their own named consts which should be more extensible.
fdnt7
added a commit
that referenced
this pull request
Jun 19, 2025
fdnt7
added a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild
lyra_proccrate if.envis changed, left out of #64. This makes the/playsources to be reevaluated every time.envchanges, instead of incorrectly on every cold build.