Skip to content

fix: sync /play src opt choices w/ .env at runtime #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2025
Merged

fix: sync /play src opt choices w/ .env at runtime #90

merged 2 commits into from
Jun 19, 2025

Conversation

fdnt7
Copy link
Member

@fdnt7 fdnt7 commented Jun 18, 2025

Sync /play's 'source' option choices with enabled play sources enabled in .env at runtime instead of build time. This allows prebuilt images to declare the new source option choices when .env is changed accordingly.

refs: #64, #77

@fdnt7
fix: sync /play src opt choices w/ .env at runtime
87ddcc1 
Sync `/play`'s 'source' option choices with enabled play sources enabled
in `.env` at runtime instead of build time. This allows prebuilt images
to declare the new source option choices when `.env` is changed
accordingly.

refs: #64, #77
@fdnt7 fdnt7 added this to the v0.9.2 milestone Jun 18, 2025
@fdnt7 fdnt7 self-assigned this Jun 18, 2025
fdnt7
fdnt7 commented Jun 18, 2025
View reviewed changes
fdnt7
fdnt7 commented Jun 18, 2025
View reviewed changes
Copy link
Member Author

@fdnt7 fdnt7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is untested. Testing on a local bot is needed to ensure that the behaviour works.

I will now go dining out for approximately 3 hours.

@fdnt7
fix: include display_name in runtime .env syncing
9634d04 
Also refactor string literals out to their own named consts which should
be more extensible.
@fdnt7 fdnt7 merged commit d502fd8 into main Jun 19, 2025
3 checks passed
@fdnt7 fdnt7 deleted the bugfix/pull-64-runtime branch June 19, 2025 13:04
@fdnt7 fdnt7 mentioned this pull request Jun 19, 2025
Merged
fdnt7 added a commit that referenced this pull request Jun 19, 2025
@fdnt7
fix: pass missing env vars in compose.example.yaml
7d64a20 
Pass missing environment variables the bot image needs in the example
docker compose file: `PLUGINS_LAVASRC_SOURCES_DEEZER`,
`PLUGINS_LAVASRC_SOURCES_SPOTIFY` and `PLUGINS_YOUTUBE_OAUTH_ENABLED`.

refs: #64, #66, #77, #90
fdnt7 added a commit that referenced this pull request Jun 19, 2025
@fdnt7
fix: pass missing env vars in compose.example.yaml (#93)
a4093c8 
Pass missing environment variables the bot image needs in the example
docker compose file: `PLUGINS_LAVASRC_SOURCES_DEEZER`,
`PLUGINS_LAVASRC_SOURCES_SPOTIFY` and `PLUGINS_YOUTUBE_OAUTH_ENABLED`.

refs: #64, #66, #77, #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fdnt7 fdnt7

Labels
None yet
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
1 participant
@fdnt7