Skip to content

fix(contract-verifier): Ignore suppressable errors during compilation #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(contract-verifier): Ignore suppressable errors during compilation #3747

merged 1 commit into from
Mar 21, 2025

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Mar 21, 2025

Needed for zkSync-Community-Hub/zksync-developers#834

For old compiler versions (e.g. zksolc 1.5.4), suppressedErrors wasn't a part of compiler settings, so we cannot easily pass it to the contract verifier without changing a lot of components. Moreover, it's not a "real" error but a "heavy warning". If the contract was compiled and deployed with this warning, we should still allow verifying it.

hedgar2017
hedgar2017 reviewed Mar 21, 2025
View reviewed changes
Copy link

@hedgar2017 hedgar2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would avoid relying on any markers or message substrings.
I'm not sure if versions older than v1.5.4 include these instructions in their error messages.

@popzxc popzxc enabled auto-merge March 21, 2025 11:29
@popzxc popzxc added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit a5955c4 Mar 21, 2025
37 checks passed
@popzxc popzxc deleted the popzxc-ignore-suppressable-errors branch March 21, 2025 12:23
@zksync-era-bot zksync-era-bot mentioned this pull request Mar 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 21, 2025
@zksync-era-bot
chore(main): release core 27.0.0 (#3686)
3e9fc0a 
🤖 I have created a release *beep* *boop*
---


##
[27.0.0](core-v26.7.0...core-v27.0.0)
(2025-03-21)


### ⚠ BREAKING CHANGES

* Remove old prover stack
([#3729](#3729))
* V27 update
([#3580](#3580))

### Features

* **eigenda:** EigenDA M0
([#3650](#3650))
([2a3cae9](2a3cae9))
* **eth-watch:** split heavy get logs requests if 503
([#3706](#3706))
([406a3ff](406a3ff))
* **gateway:** Requirement to stop L1->L2 transactions before v26
upgrade ([#3707](#3707))
([0a095b7](0a095b7))
* Remove old prover stack
([#3729](#3729))
([fbbdc76](fbbdc76))
* Starting from v26 version, always fetch the address of the validator
timelock from CTM
([#3721](#3721))
([d3db521](d3db521))
* **storage:** rocksdb storage extension for zkos
([#3698](#3698))
([2779245](2779245))
* Use JSON-RPC for core <> prover interaction
([#3626](#3626))
([4e74730](4e74730))
* V27 update
([#3580](#3580))
([9e18550](9e18550))
* **zksync_tee_prover:** add support for TDX and None TEE types
([#3711](#3711))
([11d166b](11d166b))
* **zksync_tee_prover:** read config in TDX from google metadata
([#3702](#3702))
([e50201c](e50201c))


### Bug Fixes

* **contract-verifier:** Allow reverification of system contracts in Yul
([#3735](#3735))
([e99b548](e99b548))
* **contract-verifier:** contract verifier to return fully matched
verification info when available
([#3734](#3734))
([1a0f27f](1a0f27f))
* **contract-verifier:** Correctly process partial verification for EVM
contracts
([#3688](#3688))
([8292234](8292234))
* **contract-verifier:** Ignore suppressable errors during compilation
([#3747](#3747))
([a5955c4](a5955c4))
* **data-availability-fetcher:** prevent EN database from being
populated with unnecessary inclusion data
([#3742](#3742))
([037bac3](037bac3))
* make eigenda_eth_rpc in Eigen config optional in file-based configs
([#3732](#3732))
([69d0efc](69d0efc))
* make secret optionnal when da client object store is selected
([#3715](#3715))
([f05fffd](f05fffd))
* Serialization issues
([#3589](#3589))
([606d5af](606d5af))
* **vm:** Fix another VM divergence in validation
([#3675](#3675))
([85dfc13](85dfc13))


### Performance Improvements

* **zkos:** Choose optimal amortization radix for ZK OS Merkle tree
([#3685](#3685))
([fc1e230](fc1e230))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
zkzoomer pushed a commit that referenced this pull request Jun 21, 2025
@zksync-era-bot
chore(main): release core 27.0.0 (#3686)
1800aea 
🤖 I have created a release *beep* *boop*
---


##
[27.0.0](core-v26.7.0...core-v27.0.0)
(2025-03-21)


### ⚠ BREAKING CHANGES

* Remove old prover stack
([#3729](#3729))
* V27 update
([#3580](#3580))

### Features

* **eigenda:** EigenDA M0
([#3650](#3650))
([2a3cae9](2a3cae9))
* **eth-watch:** split heavy get logs requests if 503
([#3706](#3706))
([406a3ff](406a3ff))
* **gateway:** Requirement to stop L1-&gt;L2 transactions before v26
upgrade ([#3707](#3707))
([867cfa5](867cfa5))
* Remove old prover stack
([#3729](#3729))
([4a001a7](4a001a7))
* Starting from v26 version, always fetch the address of the validator
timelock from CTM
([#3721](#3721))
([d3db521](d3db521))
* **storage:** rocksdb storage extension for zkos
([#3698](#3698))
([2779245](2779245))
* Use JSON-RPC for core &lt;&gt; prover interaction
([#3626](#3626))
([1971fe4](1971fe4))
* V27 update
([#3580](#3580))
([e7e930e](e7e930e))
* **zksync_tee_prover:** add support for TDX and None TEE types
([#3711](#3711))
([11d166b](11d166b))
* **zksync_tee_prover:** read config in TDX from google metadata
([#3702](#3702))
([e50201c](e50201c))


### Bug Fixes

* **contract-verifier:** Allow reverification of system contracts in Yul
([#3735](#3735))
([e99b548](e99b548))
* **contract-verifier:** contract verifier to return fully matched
verification info when available
([#3734](#3734))
([1a0f27f](1a0f27f))
* **contract-verifier:** Correctly process partial verification for EVM
contracts
([#3688](#3688))
([8292234](8292234))
* **contract-verifier:** Ignore suppressable errors during compilation
([#3747](#3747))
([a5955c4](a5955c4))
* **data-availability-fetcher:** prevent EN database from being
populated with unnecessary inclusion data
([#3742](#3742))
([037bac3](037bac3))
* make eigenda_eth_rpc in Eigen config optional in file-based configs
([#3732](#3732))
([69d0efc](69d0efc))
* make secret optionnal when da client object store is selected
([#3715](#3715))
([f05fffd](f05fffd))
* Serialization issues
([#3589](#3589))
([606d5af](606d5af))
* **vm:** Fix another VM divergence in validation
([#3675](#3675))
([85dfc13](85dfc13))


### Performance Improvements

* **zkos:** Choose optimal amortization radix for ZK OS Merkle tree
([#3685](#3685))
([fc1e230](fc1e230))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
dutterbutter pushed a commit to dutterbutter/zkstack-cli that referenced this pull request Jul 3, 2025
@zksync-era-bot
chore(main): release core 27.0.0 (#3686)
f7df5f0 
🤖 I have created a release *beep* *boop*
---


##
[27.0.0](matter-labs/zksync-era@core-v26.7.0...core-v27.0.0)
(2025-03-21)


### ⚠ BREAKING CHANGES

* Remove old prover stack
([#3729](matter-labs/zksync-era#3729))
* V27 update
([#3580](matter-labs/zksync-era#3580))

### Features

* **eigenda:** EigenDA M0
([#3650](matter-labs/zksync-era#3650))
([2a3cae9](matter-labs/zksync-era@2a3cae9))
* **eth-watch:** split heavy get logs requests if 503
([#3706](matter-labs/zksync-era#3706))
([406a3ff](matter-labs/zksync-era@406a3ff))
* **gateway:** Requirement to stop L1-&gt;L2 transactions before v26
upgrade ([#3707](matter-labs/zksync-era#3707))
([1fea419](matter-labs/zksync-era@1fea419))
* Remove old prover stack
([#3729](matter-labs/zksync-era#3729))
([ba05a88](matter-labs/zksync-era@ba05a88))
* Starting from v26 version, always fetch the address of the validator
timelock from CTM
([#3721](matter-labs/zksync-era#3721))
([d3db521](matter-labs/zksync-era@d3db521))
* **storage:** rocksdb storage extension for zkos
([#3698](matter-labs/zksync-era#3698))
([2779245](matter-labs/zksync-era@2779245))
* Use JSON-RPC for core &lt;&gt; prover interaction
([#3626](matter-labs/zksync-era#3626))
([6a6cead](matter-labs/zksync-era@6a6cead))
* V27 update
([#3580](matter-labs/zksync-era#3580))
([6548ace](matter-labs/zksync-era@6548ace))
* **zksync_tee_prover:** add support for TDX and None TEE types
([#3711](matter-labs/zksync-era#3711))
([11d166b](matter-labs/zksync-era@11d166b))
* **zksync_tee_prover:** read config in TDX from google metadata
([#3702](matter-labs/zksync-era#3702))
([e50201c](matter-labs/zksync-era@e50201c))


### Bug Fixes

* **contract-verifier:** Allow reverification of system contracts in Yul
([#3735](matter-labs/zksync-era#3735))
([e99b548](matter-labs/zksync-era@e99b548))
* **contract-verifier:** contract verifier to return fully matched
verification info when available
([#3734](matter-labs/zksync-era#3734))
([1a0f27f](matter-labs/zksync-era@1a0f27f))
* **contract-verifier:** Correctly process partial verification for EVM
contracts
([#3688](matter-labs/zksync-era#3688))
([8292234](matter-labs/zksync-era@8292234))
* **contract-verifier:** Ignore suppressable errors during compilation
([#3747](matter-labs/zksync-era#3747))
([a5955c4](matter-labs/zksync-era@a5955c4))
* **data-availability-fetcher:** prevent EN database from being
populated with unnecessary inclusion data
([#3742](matter-labs/zksync-era#3742))
([037bac3](matter-labs/zksync-era@037bac3))
* make eigenda_eth_rpc in Eigen config optional in file-based configs
([#3732](matter-labs/zksync-era#3732))
([69d0efc](matter-labs/zksync-era@69d0efc))
* make secret optionnal when da client object store is selected
([#3715](matter-labs/zksync-era#3715))
([f05fffd](matter-labs/zksync-era@f05fffd))
* Serialization issues
([#3589](matter-labs/zksync-era#3589))
([606d5af](matter-labs/zksync-era@606d5af))
* **vm:** Fix another VM divergence in validation
([#3675](matter-labs/zksync-era#3675))
([85dfc13](matter-labs/zksync-era@85dfc13))


### Performance Improvements

* **zkos:** Choose optimal amortization radix for ZK OS Merkle tree
([#3685](matter-labs/zksync-era#3685))
([fc1e230](matter-labs/zksync-era@fc1e230))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasyl-ivanchuk vasyl-ivanchuk vasyl-ivanchuk approved these changes

@hedgar2017 hedgar2017 hedgar2017 approved these changes

@perekopskiy perekopskiy perekopskiy approved these changes

@slowli slowli Awaiting requested review from slowli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@popzxc @vasyl-ivanchuk @hedgar2017 @perekopskiy