fix(rhino): more lenient creation for failed/partial instances #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhankoral
approved these changes
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #431 +/- ##
=====================================
Coverage 9.34% 9.34%
=====================================
Files 224 224
Lines 4246 4246
Branches 471 471
=====================================
Hits 397 397
Misses 3833 3833
Partials 16 16 ☔ View full report in Codecov by Sentry. |
oguzhankoral
deleted the
dimitrie/cnx-764-some-transforms-are-incorrectly-applied
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats the issue described in the linear ticket, but the root cause of the problem is most likely somewhere on the creation side of things (sketchup) OR in rhino's mesh to host converter.
This is a welcome addition (viewer behaves the same way), where we don't fail instance creation if one object from its definition is missing.