Skip to content

fix(rhino): more lenient creation for failed/partial instances #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(rhino): more lenient creation for failed/partial instances #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2be43
fix(rhino): more lenient creation for failed/partial instances
didimitrie Dec 2, 2024
0ac4a24
Merge branch 'dev' into dimitrie/cnx-764-some-transforms-are-incorrec…
oguzhankoral Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Connectors/Rhino/Speckle.Connectors.RhinoShared/HostApp/RhinoInstanceBaker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ IProgress<CardProgress> onOperationProgressed
foreach (var id in currentApplicationObjectsIds)
{
var docObject = doc.Objects.FindId(new Guid(id));
// NOTE: we're here being lenient on incomplete block creation. If a block contains unsupported elements that somehow threw/didn't manage to get baked as atomic objects,
// we just continue rather than throw on a null when accessing the docObject's Geometry.
if (docObject is null)
{
continue;
}
definitionGeometryList.Add(docObject.Geometry);
attributes.Add(docObject.Attributes);
}
Expand Down
Loading