Skip to content

Conversation

matt-fidd
Copy link
Member

@matt-fidd matt-fidd commented Aug 6, 2025

Merge after #5497 & #5498

@actual-github-bot actual-github-bot bot changed the title ♻️ bump eslint-plugin-actual dependencies [WIP] ♻️ bump eslint-plugin-actual dependencies Aug 6, 2025
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 35591fd
🔍 Latest deploy log https://app.netlify.com/projects/actualbudget/deploys/68abda492c9c730008d2f689
😎 Deploy Preview https://deploy-preview-5499.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matt-fidd matt-fidd added the dependencies Pull requests that update a dependency file label Aug 6, 2025
@matt-fidd matt-fidd changed the title [WIP] ♻️ bump eslint-plugin-actual dependencies ♻️ bump eslint-plugin-actual dependencies Aug 6, 2025
@matt-fidd matt-fidd changed the title ♻️ bump eslint-plugin-actual dependencies [WIP] ♻️ bump eslint-plugin-actual dependencies Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
23 10.75 MB → 10.86 MB (+109.79 kB) +1.00%
Changeset
File Δ Size
node_modules/@react-aria/dnd/dist/DropTargetKeyboardNavigation.mjs 🆕 +9.84 kB 0 B → 9.84 kB
node_modules/@react-aria/utils/dist/useLoadMoreSentinel.mjs 🆕 +2.55 kB 0 B → 2.55 kB
node_modules/@react-aria/utils/dist/isElementVisible.mjs 🆕 +2.27 kB 0 B → 2.27 kB
node_modules/react-aria-components/dist/Group.mjs 🆕 +720 B 0 B → 720 B
node_modules/@react-aria/utils/dist/inertValue.mjs 🆕 +269 B 0 B → 269 B
node_modules/react-aria-components/dist/Collection.mjs 📈 +1.22 kB (+78.32%) 1.55 kB → 2.77 kB
node_modules/@react-aria/utils/dist/filterDOMProps.mjs 📈 +1.11 kB (+66.75%) 1.66 kB → 2.77 kB
node_modules/@react-aria/utils/dist/useObjectRef.mjs 📈 +647 B (+56.90%) 1.11 kB → 1.74 kB
node_modules/@react-aria/utils/dist/mergeRefs.mjs 📈 +497 B (+54.20%) 917 B → 1.38 kB
node_modules/@react-aria/utils/dist/useEffectEvent.mjs 📈 +511 B (+50.59%) 1010 B → 1.49 kB
node_modules/react-aria-components/dist/DragAndDrop.mjs 📈 +1.7 kB (+43.71%) 3.89 kB → 5.59 kB
node_modules/@react-stately/color/dist/useColorChannelFieldState.mjs 📈 +631 B (+35.89%) 1.72 kB → 2.33 kB
node_modules/@react-aria/dnd/dist/DragManager.mjs 📈 +5.49 kB (+27.58%) 19.92 kB → 25.41 kB
node_modules/@react-stately/dnd/dist/useDraggableCollectionState.mjs 📈 +726 B (+23.11%) 3.07 kB → 3.78 kB
node_modules/@react-aria/form/dist/useFormValidation.mjs 📈 +933 B (+18.50%) 4.93 kB → 5.84 kB
node_modules/@react-aria/dnd/dist/DragPreview.mjs 📈 +357 B (+17.39%) 2 kB → 2.35 kB
node_modules/react-aria-components/dist/ColorSwatch.mjs 📈 +145 B (+16.51%) 878 B → 1023 B
node_modules/@react-aria/dnd/dist/useDropIndicator.mjs 📈 +595 B (+15.01%) 3.87 kB → 4.45 kB
node_modules/react-aria-components/dist/ListBox.mjs 📈 +2.11 kB (+15.01%) 14.04 kB → 16.14 kB
node_modules/@react-stately/dnd/dist/useDroppableCollectionState.mjs 📈 +822 B (+14.29%) 5.62 kB → 6.42 kB
node_modules/react-aria-components/dist/Dialog.mjs 📈 +473 B (+13.79%) 3.35 kB → 3.81 kB
node_modules/react-aria-components/dist/GridList.mjs 📈 +1.98 kB (+13.53%) 14.64 kB → 16.62 kB
node_modules/@react-aria/overlays/dist/ariaHideOutside.mjs 📈 +766 B (+11.78%) 6.35 kB → 7.1 kB
node_modules/@react-stately/utils/dist/number.mjs 📈 +279 B (+11.53%) 2.36 kB → 2.63 kB
node_modules/@react-aria/dnd/dist/useDrag.mjs 📈 +1.28 kB (+10.77%) 11.86 kB → 13.14 kB
node_modules/@react-aria/button/dist/useButton.mjs 📈 +280 B (+9.71%) 2.82 kB → 3.09 kB
node_modules/@react-aria/color/dist/useColorField.mjs 📈 +229 B (+6.66%) 3.36 kB → 3.58 kB
node_modules/@internationalized/number/dist/NumberParser.mjs 📈 +953 B (+6.16%) 15.12 kB → 16.05 kB
node_modules/react-aria-components/dist/ColorField.mjs 📈 +336 B (+5.77%) 5.69 kB → 6.02 kB
node_modules/react-aria-components/dist/Popover.mjs 📈 +423 B (+5.40%) 7.65 kB → 8.06 kB
node_modules/@react-aria/textfield/dist/useTextField.mjs 📈 +235 B (+4.57%) 5.03 kB → 5.25 kB
node_modules/@react-aria/dialog/dist/useDialog.mjs 📈 +140 B (+4.51%) 3.03 kB → 3.17 kB
node_modules/@react-stately/collections/dist/getItemCount.mjs 📈 +54 B (+4.31%) 1.22 kB → 1.28 kB
node_modules/@react-aria/collections/dist/Document.mjs 📈 +679 B (+4.11%) 16.14 kB → 16.81 kB
node_modules/@react-stately/color/dist/useColorFieldState.mjs 📈 +230 B (+3.88%) 5.79 kB → 6.02 kB
node_modules/@react-aria/dnd/dist/useDroppableItem.mjs 📈 +93 B (+3.37%) 2.69 kB → 2.78 kB
node_modules/@react-aria/interactions/dist/usePress.mjs 📈 +611 B (+3.31%) 18.04 kB → 18.63 kB
node_modules/@react-aria/overlays/dist/useModalOverlay.mjs 📈 +46 B (+3.28%) 1.37 kB → 1.41 kB
node_modules/@react-aria/selection/dist/useSelectableItem.mjs 📈 +412 B (+3.14%) 12.81 kB → 13.21 kB
node_modules/@react-aria/gridlist/dist/useGridList.mjs 📈 +100 B (+3.13%) 3.12 kB → 3.22 kB
node_modules/@react-aria/selection/dist/useSelectableCollection.mjs 📈 +720 B (+2.96%) 23.78 kB → 24.49 kB
node_modules/@react-aria/grid/dist/useGridSelectionAnnouncement.mjs 📈 +147 B (+2.88%) 4.98 kB → 5.13 kB
node_modules/react-aria-components/dist/Tooltip.mjs 📈 +147 B (+2.84%) 5.05 kB → 5.19 kB
node_modules/@react-aria/overlays/dist/usePreventScroll.mjs 📈 +305 B (+2.55%) 11.68 kB → 11.98 kB
node_modules/@react-aria/collections/dist/BaseCollection.mjs 📈 +271 B (+2.24%) 11.79 kB → 12.06 kB
node_modules/@react-stately/numberfield/dist/useNumberFieldState.mjs 📈 +181 B (+1.84%) 9.59 kB → 9.77 kB
locale/de.json 📈 +2.18 kB (+1.56%) 140.13 kB → 142.32 kB
node_modules/@react-aria/selection/dist/useTypeSelect.mjs 📈 +50 B (+1.55%) 3.15 kB → 3.2 kB
node_modules/@react-aria/interactions/dist/useHover.mjs 📈 +58 B (+1.54%) 3.69 kB → 3.75 kB
node_modules/@react-aria/numberfield/dist/useNumberField.mjs 📈 +163 B (+1.35%) 11.75 kB → 11.91 kB
node_modules/@react-aria/overlays/dist/usePopover.mjs 📈 +36 B (+1.24%) 2.83 kB → 2.87 kB
node_modules/react-aria-components/dist/useDragAndDrop.mjs 📈 +26 B (+0.89%) 2.87 kB → 2.89 kB
node_modules/@react-aria/gridlist/dist/useGridListItem.mjs 📈 +83 B (+0.58%) 13.93 kB → 14.01 kB
locale/fr.json 📈 +825 B (+0.54%) 149.26 kB → 150.07 kB
locale/uk.json 📈 +893 B (+0.47%) 185.02 kB → 185.9 kB
node_modules/@react-aria/spinbutton/dist/useSpinButton.mjs 📈 +29 B (+0.43%) 6.59 kB → 6.62 kB
node_modules/@react-aria/focus/dist/virtualFocus.mjs 📈 +4 B (+0.32%) 1.23 kB → 1.23 kB
node_modules/@react-aria/interactions/dist/useFocus.mjs 📈 +8 B (+0.32%) 2.46 kB → 2.47 kB
node_modules/@react-aria/utils/dist/useUpdateLayoutEffect.mjs 📈 +4 B (+0.30%) 1.31 kB → 1.31 kB
node_modules/@react-aria/utils/dist/keyboard.mjs 📈 +2 B (+0.26%) 773 B → 775 B
node_modules/@react-aria/utils/dist/useSyncRef.mjs 📈 +2 B (+0.21%) 954 B → 956 B
node_modules/@react-aria/interactions/dist/useFocusWithin.mjs 📈 +8 B (+0.18%) 4.35 kB → 4.35 kB
node_modules/@react-aria/focus/dist/useHasTabbableChild.mjs 📈 +4 B (+0.17%) 2.29 kB → 2.29 kB
node_modules/@react-aria/overlays/dist/Overlay.mjs 📈 +4 B (+0.17%) 2.33 kB → 2.34 kB
node_modules/@react-aria/utils/dist/openLink.mjs 📈 +6 B (+0.15%) 3.79 kB → 3.8 kB
node_modules/@react-aria/interactions/dist/textSelection.mjs 📈 +6 B (+0.15%) 3.97 kB → 3.97 kB
node_modules/react-aria-components/dist/ProgressBar.mjs 📈 +1 B (+0.14%) 724 B → 725 B
node_modules/@react-aria/interactions/dist/useFocusable.mjs 📈 +2 B (+0.11%) 1.71 kB → 1.71 kB
node_modules/@react-aria/utils/dist/animation.mjs 📈 +4 B (+0.11%) 3.55 kB → 3.55 kB
node_modules/@react-aria/utils/dist/useDescription.mjs 📈 +2 B (+0.10%) 1.86 kB → 1.86 kB
node_modules/@react-aria/utils/dist/useValueEffect.mjs 📈 +2 B (+0.10%) 1.87 kB → 1.87 kB
node_modules/@react-aria/interactions/dist/useLongPress.mjs 📈 +4 B (+0.10%) 3.77 kB → 3.77 kB
locale/es.json 📈 +59 B (+0.08%) 71.41 kB → 71.47 kB
node_modules/@react-aria/overlays/dist/useOverlayPosition.mjs 📈 +6 B (+0.05%) 11.4 kB → 11.41 kB
node_modules/@react-aria/tooltip/dist/useTooltipTrigger.mjs 📈 +2 B (+0.05%) 3.89 kB → 3.89 kB
node_modules/@react-aria/listbox/dist/useOption.mjs 📈 +2 B (+0.03%) 6.07 kB → 6.08 kB
node_modules/react-aria-components/dist/utils.mjs 📈 +2 B (+0.03%) 6.27 kB → 6.27 kB
node_modules/@react-aria/collections/dist/CollectionBuilder.mjs 📈 +2 B (+0.02%) 11.38 kB → 11.38 kB
src/components/mobile/transactions/TransactionListItem.tsx 📉 -20 B (-0.23%) 8.37 kB → 8.35 kB
node_modules/@react-aria/focus/dist/FocusScope.mjs 📉 -164 B (-0.45%) 35.87 kB → 35.71 kB
node_modules/@react-aria/interactions/dist/useInteractOutside.mjs 📉 -18 B (-0.92%) 1.91 kB → 1.89 kB
node_modules/@react-aria/dnd/dist/constants.mjs 📉 -73 B (-3.26%) 2.19 kB → 2.12 kB
node_modules/react-aria-components/dist/Button.mjs 📉 -221 B (-4.29%) 5.03 kB → 4.81 kB
node_modules/@react-aria/utils/dist/useFormReset.mjs 📉 -64 B (-4.60%) 1.36 kB → 1.3 kB
node_modules/@react-stately/collections/dist/getChildNodes.mjs 📉 -165 B (-5.39%) 2.99 kB → 2.83 kB
node_modules/@react-aria/dnd/dist/useDroppableCollection.mjs 📉 -5.5 kB (-15.19%) 36.23 kB → 30.72 kB
node_modules/react-aria-components/dist/Modal.mjs 📉 -1.43 kB (-21.27%) 6.74 kB → 5.3 kB
node_modules/@react-aria/interactions/dist/useFocusVisible.mjs 📉 -3.05 kB (-34.65%) 8.8 kB → 5.75 kB
node_modules/@react-aria/utils/dist/isVirtualEvent.mjs 📉 -867 B (-40.38%) 2.1 kB → 1.25 kB
node_modules/@react-aria/utils/dist/platform.mjs 📉 -1.2 kB (-46.49%) 2.58 kB → 1.38 kB
node_modules/@react-aria/utils/dist/useId.mjs 📉 -3.13 kB (-82.88%) 3.78 kB → 662 B
node_modules/@react-aria/interactions/dist/utils.mjs 📉 -6.59 kB (-99.21%) 6.64 kB → 54 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 7.83 MB → 7.92 MB (+92.28 kB) +1.15%
static/js/narrow.js 450.92 kB → 464.51 kB (+13.59 kB) +3.01%
static/js/de.js 140.13 kB → 142.32 kB (+2.18 kB) +1.56%
static/js/uk.js 185.02 kB → 185.9 kB (+893 B) +0.47%
static/js/fr.js 149.26 kB → 150.07 kB (+825 B) +0.54%
static/js/es.js 71.41 kB → 71.47 kB (+59 B) +0.08%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en-GB.js 6.84 kB 0%
static/js/en.js 128.77 kB 0%
static/js/it.js 142.04 kB 0%
static/js/nl.js 99.98 kB 0%
static/js/pl.js 86.07 kB 0%
static/js/pt-BR.js 141.84 kB 0%
static/js/sv.js 67.43 kB 0%
static/js/th.js 188.74 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ReportRouter.js 830.05 kB 0%
static/js/TransactionList.js 10.92 kB 0%
static/js/wide.js 116.99 kB 0%
static/js/useAccountPreviewTransactions.js 8.52 kB 0%
static/js/useTransactionBatchActions.js 10.22 kB 0%

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 4.28 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.qbdvDTe8.js 4.28 MB 0%

Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Aug 14, 2025
@matt-fidd matt-fidd removed the Stale label Aug 15, 2025
@joel-jeremy
Copy link
Contributor

Similar thing happening with #5498. The tests need to be updated to be more specific on the search. We need to find the parent/containing element first e.g. tooltip/dialog and then search from there.

image

@matt-fidd matt-fidd marked this pull request as draft August 26, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants