[WIP] ♻️ bump component-library dependencies #5498
Open
+1,831
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
This was referenced Aug 6, 2025
matt-fidd
changed the title
WalkthroughThis change updates dependency versions in the package.json files for both the component-library and desktop-client packages, specifically increasing the versions of react-aria-components, react, react-dom, and @types/react. Additionally, the TransactionListItem component in the desktop-client package receives a type definition update: the props type now omits onPress and onLongPress from inherited ListBoxItem props, explicitly requires a value property of type TransactionEntity, and directly destructures this value as transaction in the function signature. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/typescript.mdc)
Files:
**/*.tsx📄 CodeRabbit Inference Engine (.cursor/rules/typescript.mdc)
Files:
🧠 Learnings (30)📓 Common learnings📚 Learning: the `listbox` component from `react-aria-components` supports the `dependencies` prop....Applied to files:
📚 Learning: variables defined within react hooks like `usememo` or `useeffect` are not dependencies of other hoo...Applied to files:
📚 Learning: in this codebase, eslint requires `dispatch` from `usedispatch` to be included in the dependency arr...Applied to files:
📚 Learning: in the project's react components, when using `dispatch` from `usedispatch` in `usecallback` or `use...Applied to files:
📚 Learning: typescript configuration and entry points for the @actual-app/components package will be added when ...Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : favor named exports for components and utilities....Applied to files:
📚 Learning: in our react function components, we should include `dispatch` in the dependency array of `usecallba...Applied to files:
📚 Learning: jest testing framework is used in multiple packages (api, crdt, loot-core) while desktop-client uses...Applied to files:
📚 Learning: applies to **/*.tsx : use declarative jsx, keeping jsx minimal and readable....Applied to files:
📚 Learning: in react router v7, browserrouter and other dom-specific components are exported from the main 'reac...Applied to files:
📚 Learning: in `packages/desktop-client/src/components/transactions/selectedtransactionsbutton.tsx`, prefer to k...Applied to files:
📚 Learning: in `packages/desktop-client/src/components/mobile/transactions/transactionedit.jsx`, within the `one...Applied to files:
📚 Learning: in the `transaction` component in `transaction.tsx`, both `rawtransaction` and `transaction` should ...Applied to files:
📚 Learning: in the cellvalue component of packages/desktop-client/src/components/spreadsheet/cellvalue.tsx, the ...Applied to files:
📚 Learning: in the react `usetransactions` hook defined in `packages/loot-core/src/client/data-hooks/transaction...Applied to files:
📚 Learning: the `onreorder` function in `accounts.tsx` was moved from `sidebar.tsx`, and the `targetid` paramete...Applied to files:
📚 Learning: in the `alltransactions` component of `account.tsx`, the `uselayouteffect` hook is appropriately use...Applied to files:
📚 Learning: the account component in 'packages/desktop-client/src/components/accounts/account.tsx' is being rewr...Applied to files:
📚 Learning: in 'packages/desktop-client/src/components/sidebar/budgetname.tsx', empty budget names are handled e...Applied to files:
📚 Learning: in transactionstable.tsx, the balance calculation using find() to locate the first non-scheduled tra...Applied to files:
📚 Learning: in `calendar.tsx`, transaction-related callbacks such as `onbatchdelete`, `onbatchduplicate`, `oncre...Applied to files:
📚 Learning: in `packages/desktop-client/src/components/sidebar/budgetname.tsx`, the `budgetname` component consi...Applied to files:
📚 Learning: in the actual budget codebase, the schedule action handlers (onpost, onskip, oncomplete) in accountt...Applied to files:
📚 Learning: in the `desktop-electron` module, `loot-core`'s essential files are intentionally copied during pack...Applied to files:
📚 Learning: the `tablenavigator` type in `packages/desktop-client/src/components/table.tsx` is not used outside ...Applied to files:
📚 Learning: in `packages/loot-core/src/types/util.d.ts`, `transobjectliteral` remains typed as `any` due to the ...Applied to files:
📚 Learning: in react 19, function components can receive refs directly through props without requiring react.for...Applied to files:
📚 Learning: react 19 has simplified ref handling, eliminating the need for `react.forwardref()` in functional co...Applied to files:
📚 Learning: in `packages/desktop-client/src/components/columnwidthcontext.jsx`, replacing `usestate` with `usere...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
matt-fidd
changed the title
matt-fidd
force-pushed
the
deps/component-library
branch
from
578fb51 to
ae36efe
Compare
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
matt-fidd
force-pushed
the
deps/component-library
branch
3 times, most recently
from
3a0be83 to
2f92da1
Compare
|
The test is failing because it searches the entire page for the 
|
I've tried this a few ways and not had any luck, I'm not very familiar with the playwright e2e stuff and I'm struggling to get them to target correctly. Any ideas how I could approach it? |
matt-fidd
force-pushed
the
deps/component-library
branch
from
2f92da1 to
b6728e2
Compare
matt-fidd
force-pushed
the
deps/component-library
branch
from
b6728e2 to
86f4e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #5497
Nothing major here, just incremental improvements.