blockifier: unify from felts and from bytecode to counts

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-08-20T11:49:59Z
• Started at 2025-08-20T13:15:52Z
• Started at 2025-08-20T13:30:58Z

[avivg-starkware]

• blockifier: unify from felts and from bytecode to counts #8716 👈 (View in Graphite)
• blockifier: change input to felt_size_counts: fn encode_blake #8686 : 1 other dependent PR (#8701 )
• blockifier: fn cost_of_encode_: get estimated_er and convert to gas #8641 : 1 other dependent PR (#8624 )
• blockifier: fn encode_and_blake_hash_resources return estimated_er #8618 : 1 other dependent PR (#8642 )
• blockifier: allow from estimated_execution_resources to er and back #8663
• blockifier: impl trait execution_resources_estimator #8536
• blockifier: add trait execution_resources_estimator #8529
• blockifier: add assign estimate_execution_resources #8527
• blockifier: add struct estimate_execution_resources #8526
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avivg-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

---

crates/blockifier/src/execution/contract_class.rs line 99 at r1 (raw file):

impl From<&[BigUintAsHex]> for FeltSizeCount {
    fn from(bytecode: &[BigUintAsHex]) -> Self {
        count_felts_by_size(bytecode, |x| Felt::from(&x.value) < SMALL_THRESHOLD)

Alternative

Suggestion (i):

x.value.bits() <= SMALL_THRESHOLD_BITS

Code snippet (ii):

const SMALL_THRESHOLD_BITS: u32 = 63;

#[test]
    fn small_threshold_consistency() {
        let reconstructed = Felt::from(1u128 << SMALL_THRESHOLD_BITS);
        assert_eq!(reconstructed, SMALL_THRESHOLD);
    }

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 108 at r1 (raw file):

        count_felts_by_size(bytecode, |felt| *felt < SMALL_THRESHOLD)
    }
}

You need to impl from only once,

from <T> for  FeltSizeCount where T impl is small 

you can fo it,

but I prefer new function that get T as an input

Code quote:

/// Counts elements into “small” vs “large” buckets using the provided predicate.
#[inline]
fn count_felts_by_size<T>(slice: &[T], mut is_small: impl FnMut(&T) -> bool) -> FeltSizeCount {
    let mut small = 0;
    let mut large = 0;
    for it in slice {
        if is_small(it) { small += 1 } else { large += 1 }
    }
    FeltSizeCount { small, large }
}

/// Classifies bytecode words by felt size using `SMALL_THRESHOLD = 2^63`.
impl From<&[BigUintAsHex]> for FeltSizeCount {
    fn from(bytecode: &[BigUintAsHex]) -> Self {
        count_felts_by_size(bytecode, |x| Felt::from(&x.value) < SMALL_THRESHOLD)
    }
}

/// Classifies felts by size using `SMALL_THRESHOLD = 2^63`.
impl From<&[Felt]> for FeltSizeCount {
    fn from(bytecode: &[Felt]) -> Self {
        count_felts_by_size(bytecode, |felt| *felt < SMALL_THRESHOLD)
    }
}

[avivg-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 108 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

You need to impl from only once,

from <T> for  FeltSizeCount where T impl is small 

you can fo it,

but I prefer new function that get T as an input

WDYT?